i just created a pull request for my Z32F06423AKE MCU.
Travis says it’s okay, but the other two symbols in the Zilog Library (Z80CPU and Z8530 i believe) are faulty and therefore, Travis exits with return code 1.
Are there any other libs that are faulty by default?
I will repair this as i find some time for this.
Your pull request changed the two other symbols. (see tab: changed files.)
I think it changed the order of some lines.
This is why travis does check these other symbols. (Travis is configured to only look at changed symbols.)
But I didn’t touch the Z80CPU and Z8530 at all.
Well, nevermind… i’ve corrected the double inversion and set the datasheet field of the Z8530 to “none” (There is none in fact…) and now Travis is happy…
git diff disagrees.
(as i said above the order of some lines did change. Originally the lines starting with S where behind all the lines starting with x, after your first change these lines moved to the front of the lines starting with x.)
The checksum is done by concatenating all the lines then doing an md5 hash, so it’s sensitive to line order. Possibly, sorting the data before running through md5 would remove sensitivity to line order and not break update detection, but I haven’t thought through all the scenarios where line order might matter. I can’t think of any right now.
I’ve always found the use of bubble or overbar (or “#”, “/” “n”, “*” etc) quite variable.
An advantage with NOT using the bubble in KiCad is that it allows shorter pins and maintain legibilty. KiCad centres the text in the pin regardless of the bubble. At 150 mil, the pin number starts to overlap the bubble.
In order to comply with KLC and also keep symbols compact and legible, I am using overbar in preference to bubbles in the new 74xx lib. I am not sure this is the best way, but “legibility” is quite hard for a script to determine, so I have adopted a simple and consistent rule.