Kv8: missing 'AddPrimitiveArc'

maui · April 3, 2024, 12:21pm

as in the title it seems kv8 pcbnew.py is missing AddPrimitiveArc function definition

error:

PAD object has no attribute AddPrimitiveArc

craftyjon · April 3, 2024, 12:31pm

That sounds like the old custom pad system, which was deprecated in V7 and removed in V8. Probably the new system needs to be exposed somehow. What does your plugin do with custom pads?

Edit: the new APIs are already exposed as Mark writes below

marekr · April 3, 2024, 12:32pm

AddPrimitiveArc doesn’t exist at all (not even in C++) in v8.

You have to use AddPrimitive.

maui · April 3, 2024, 12:44pm

I need to create a custom PAD as Arc

that it is what I’m using… simply doesn’t work:

github.com

easyw/RF-tools-KiCAD/blob/643bc96206416d2ea368a30e2265d891089b034a/rf_tools_wizards/uwArcPrimitive_wizard.py#L108


      
                      pad.AddPrimitive(pcbnew.wxPoint(0,rad), pcbnew.wxPoint(0,0), int(angle_D*10), (size[0]))
                  else:
                      pad.AddPrimitive(pcbnew.wxPoint(0,0), pcbnew.wxPoint(rad,0), (size[0]))
              elif hasattr(pcbnew, 'wxPoint()'): # kv7
                  if not ln:
                      pad.AddPrimitive(pcbnew.VECTOR2I(wxPoint(0,rad)), pcbnew.VECTOR2I(wxPoint(0,0)), pcbnew.EDA_ANGLE(int(angle_D*10),pcbnew.DEGREES_T), (size[0]))
                  else:
                      pad.AddPrimitive(pcbnew.VECTOR2I(wxPoint(0,0)), pcbnew.VECTOR2I(wxPoint(rad,0)), (size[0]))            
              else: # kv8
                  if not ln:
                      pad.AddPrimitive(pcbnew.VECTOR2I(int(0),int(rad)), pcbnew.VECTOR2I(int(0),int(0)), pcbnew.EDA_ANGLE(int(angle_D*10),pcbnew.DEGREES_T), (size[0])) 
                      #pad.AddPrimitive(int(0),int(rad), int(0),int(0), pcbnew.EDA_ANGLE(int(angle_D*10),pcbnew.DEGREES_T), (size[0])) 
                  else:
                      pad.AddPrimitive(pcbnew.VECTOR2I(int(0),int(0)), pcbnew.VECTOR2I(int(rad),int(0)), (size[0]))            
              return pad
          
          def smdPad(self,module,size,pos,name,ptype,angle_D,layer,solder_clearance,offs=None):
              if hasattr(pcbnew, 'D_PAD'):
                  pad = D_PAD(module)
              else:
                  pad = PAD(module)

with the error I placed above:

PAD object has no attribute AddPrimitiveArc

craftyjon · April 3, 2024, 12:45pm

Oh, yeah there is some SWIG wrapper for this function that replaces the C++

Can you please open a bug report for this?

maui · April 4, 2024, 9:32am

done here:

davidsrsb · April 5, 2024, 11:11am

I see a fix for this in todays Testing build

maui · April 9, 2024, 7:19pm

It seems the wizard tool in kv8 now is crashing the app.

uWArc footprint wizard

running it simply makes kicad v8 to crash

github.com/easyw/RF-tools-KiCAD

kv8 knowing issues

opened 01:48PM - 07 Apr 24 UTC

easyw

kv8 knowing issues: 1) uWArc footprint wizard - running it simply makes ki…cad v8 to crash - https://github.com/easyw/RF-tools-KiCAD/blob/643bc96206416d2ea368a30e2265d891089b034a/rf_tools_wizards/uwArcPrimitive_wizard.py#L108 2) via fencingtool - running via fencing with 'Remove Via violations' - https://github.com/easyw/RF-tools-KiCAD/blob/5d21e18e8f392b35081e18d93d58e45b254afdb0/via_fence_generator/viafence_action.py#L186 - https://github.com/easyw/RF-tools-KiCAD/blob/5d21e18e8f392b35081e18d93d58e45b254afdb0/via_fence_generator/viafence_action.py#L280

davidsrsb · April 9, 2024, 10:34pm

Please raise a KiCad issue as well. KiCad should not crash, it is supposed to fail gracefully

craftyjon · April 9, 2024, 11:39pm

All bets are off when using the Python SWIG interface, unfortunately. Depending on what the crash is, we may be able to fix it, but it will also generally be the case that Python plugins can crash KiCad until we stop using the SWIG interface.