With much pleasure 
I think I have to act in the same way with fork, branch etc …
So now, if I correctly understood, once the branch of the Theme is pushed into Master, it wil be deleted. And all what I have to do before to do anything else as contribution, is to refresh my Fork. Correct?
And all what I have to do before to do anything else as contribution, is to refresh my Fork. Correct?
Yes.
1 Like
I sent my branch about the API Series 500 PCB right now, but I got an error.
What did I wrong please?
Here the link: https://gitlab.com/kicad/libraries/kicad-templates/-/merge_requests/53
That is not an error, it just means that one of the repo maintainers need to review and approve your MR. Wait for kicad team to respond.
1 Like
Ah ok it’s fine.
Now, suppose that everything is ok and they merge it.
Will it be available from 8.0.2 or from 9.0?
I mean: are these contributions available in minor or major releases?
It will go into 9.0 by default but if you ask for it to be included into next 8.0 bugfix it can be cherry-picked.
1 Like
Thank you so much. I did it.
I’m happy I learned a lot of things in this thread.
Thanks a zillion
Another question please
I see this into the page of the MR.
What is it? What does it serve? Should I do anything or I ignore it?
You can ignore it, it’s just a reminder for repository maintainers that gitlab provides some automation infrastructure if needed.
1 Like
I didn’t get any feedback yet. Is this normal (not knowing procedures)?
Common etiquette is to give it a few days and if you don’t hear from the team you can mention one of these people (probably cpresser or Jon or Seth as they are more active) in the comments in your MR and they will get a notification.
1 Like
Please do not ping individuals for review of library merge requests (unless someone has already started a review conversation with you). The librarians go through the backlog regularly, and singling out individual people is considered rude.
@tormyvancool please expect that library contributions (including templates) will take much longer to review than PCM contributions. While the team is working towards the review time being shorter, it may take weeks for anyone to get to yours, and this is currently normal.
1 Like
Ah ok so I will not ping anyone. I let my MR at the stage as it is.
I guess they will go through all the points then.
Thank you so much
Ah, didn’t realize templates were part of libraries. That repo readme should have link to contributor guidelines, same as other library repos, I’ll add that.
1 Like
Let me understand: doe it means that if I can contribute also on symbol library etc in the same way, just in case?
Yes but there are more rules to follow, they are in contribution guidelines, merge request template instructions and KLC.
1 Like
Today I got this … the merging is blocked … due “rebase” but I have not clue what I have to do and why it is occurred
Can you help me on this please?
This happened because since you opened the merge request someone else (me) pushed another commit so now your branch needs to catch up to current state of the repo before it can be merged. Just press the “Rebase” link and gitlab will update your branch.
1 Like
Ah ok perfect. I “rebased” it as you suggested
Thank you so much
1 Like